Fix KML writer crash bug
authorViet-Tam Luu <viettaml@google.com>
Mon, 27 Nov 2017 23:32:52 +0000 (15:32 -0800)
committerViet-Tam Luu <viettaml@google.com>
Mon, 27 Nov 2017 23:32:52 +0000 (15:32 -0800)
commit0509c4e04e2ca2f96f0dc38b3c8c41e4be3d825a
treec6548ad696e2fe51be46eb5d215dd849504e3560
parent9ea0fcf2fb971dcb6cb12b9ed71b23003fd8d231
Fix KML writer crash bug
When Google Earth uses gpsbabel to import KML in "live" USB mode, kml_wr_position_init() is called before kml_wr_init() resulting in deferencing an uninitialized "writer" pointer. The solution is just to remove the setAutoFormatting(false) call; there's no real need for it as it doesn't measurably impact performance. Also remove other calls to remove nice formatting on timestamps (addressing a FIXME comment), and update the golden test data to match.
kml.cc
reference/earth-expertgps-track.kml
reference/earth-expertgps.kml
reference/earth-gc.kml
reference/track/gpx_garmin_extensions-kml_track.kml
reference/track/gtrnctr_power-kml.kml
reference/track/segmented_tracks-track.kml
reference/track/segmented_tracks.kml
reference/track/tracks~gpx.kml